[WIP]: Make HelloService a bit more varied/conversational

[aranasaurus]

No description provided.

[IanKeen]

Fail is due to arc4random not being available on linux, the following should work:

#if os(Linux)
import Glibc
#else
import Darwin.C
#endif

fileprivate extension Array {
    var randomElement: Element {
        #if os(Linux)
        let index = Int(random() % self.count)
        #else
        let index = Int(arc4random_uniform(UInt32(self.count)))
        #endif
        return self[index]
    }
}

but check out Int.random(min:max) first and see if that might also work?

[aranasaurus]

Yeah, that was one of the things that I knew I was going to have to address. Hadn't looked for the cross-platform Swift way yet.

[aranasaurus]

My plan was to move that extension to Common, after I make it crossplatform

[IanKeen]

awesome! 👍 😎

[aranasaurus]

So, Int.random(min:max:) works, but that comes from Vapor. So I'd need to add Vapor as a dependency to Common, in order to move it there. Which would you rather: do the #if os dance or add the dependency, or don't move it up to the framework and leave it at the Camille level?

I'm leaning toward the dance, seems like a giant hammer for a thumbtack.

[IanKeen]

ahh you're right.. I removed my Int.random due to a conflict - add the randomElement extension - if it builds on linux I'll move it to Common

[aranasaurus]

I was already mid-PR creation so... there. :)