fixed phpstan error until level 5 #27
Conversation
| @@ -532,9 +532,7 @@ protected function prepareTransfers() | |||
| } | |||
|
|
|||
| // remove the checksum | |||
| $transfer->setRecipientAddress( | |||
There was a problem hiding this comment.
removeChecksum returns a new instance of the address without a checksum.
There was a problem hiding this comment.
Okay, you are right. I've fixed it, but I think we should refactor it and don't remove checksum at this point.
| @@ -72,7 +72,7 @@ public function setAddresses(array $addresses): self | |||
| */ | |||
| public function addAddress(Address $address): self | |||
| { | |||
| $this->addresses[] = $address->removeChecksum(); | |||
There was a problem hiding this comment.
removeChecksum returns a new instance of the address without a checksum.
There was a problem hiding this comment.
See other comment, I prefer to refactor it and put it at an other point of the code.
|
Thanks for that, see my comments related to the |
| @@ -72,7 +75,7 @@ public function setAddresses(array $addresses): self | |||
| */ | |||
| public function addAddress(Address $address): self | |||
| { | |||
| $this->addresses[] = $address->removeChecksum(); | |||
There was a problem hiding this comment.
Thats not correct, if someone calls addAddress with an address including the checksum the checksum is not removed.
There was a problem hiding this comment.
Now it's removing it twice when you call setAddresses
belongs to #26