Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @feltjs/eslint-config to fix build #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dr-Electron
Copy link
Contributor

Description of change

Sems like @feltjs/eslint-config doesn't exist anymore. Not sure if it was even used in this Project, I would have expected that you have to import it in some config. So if we never used it, we can just merge this.
If we used it, there seems to be a new version by the same maintainer here, but it only works with svelte >=4 and some other changes. But maybe we could just copy the config if we really need it. I will leave that up to you.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Run locally. Output seems to be the same.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@Dr-Electron
Copy link
Contributor Author

I just realised that this is probably how you import the feltjs config?
Should I just replace it by copying the "new" config from ryanatkn (I suppose it is the same or similar)?

@Dr-Electron Dr-Electron mentioned this pull request Mar 3, 2024
3 tasks
@begonaalvarezd begonaalvarezd self-requested a review May 9, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant