Merge pull request #744 from gohornet/develop

Release v0.5.6
iotaledger · Nov 15, 2020 · 0715a16 · 0715a16
2 parents 05cba88 + a6370c2
commit 0715a16
Show file tree

Hide file tree

Showing 8 changed files with 23 additions and 8 deletions.
diff --git a/.github/workflows/build_HORNET.yml b/.github/workflows/build_HORNET.yml
@@ -14,7 +14,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v1
         with:
-          go-version: 1.15
+          go-version: 1.15.5
         id: go
 
       - name: Print Go version

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -9,7 +9,7 @@ jobs:
     name: Release
     runs-on: [ubuntu-latest]
     container:
-      image: iotmod/goreleaser-cgo-cross-compiler:1.15
+      image: iotmod/goreleaser-cgo-cross-compiler:1.15.5
       volumes: [/repo]
 
     steps:

diff --git a/.github/workflows/test_HORNET.yml b/.github/workflows/test_HORNET.yml
@@ -14,7 +14,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v1
         with:
-          go-version: 1.15
+          go-version: 1.15.5
         id: go
 
       - name: Print Go version

diff --git a/.github/workflows/test_release.yml b/.github/workflows/test_release.yml
@@ -10,7 +10,7 @@ jobs:
     name: Test release
     runs-on: [ubuntu-latest]
     container:
-      image: iotmod/goreleaser-cgo-cross-compiler:1.15
+      image: iotmod/goreleaser-cgo-cross-compiler:1.15.5
       volumes: [/repo]
 
     steps:

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,16 @@
 
 All notable changes to this project will be documented in this file.
 
+## [0.5.6] - 15.11.2020
+
+### Changed
+
+    - Updated to Go 1.15.5 (security fixes)
+
+### Fixed
+
+    - Store milestone after it was found in serachMissingMilestone
+
 ## [0.5.5] - 13.11.2020
 
 ### Changed

diff --git a/plugins/cli/plugin.go b/plugins/cli/plugin.go
@@ -20,7 +20,7 @@ import (
 
 var (
 	// AppVersion version number
-	AppVersion          = "0.5.5"
+	AppVersion          = "0.5.6"
 	LatestGithubVersion = AppVersion
 
 	// AppName app code name

diff --git a/plugins/tangle/solidifier.go b/plugins/tangle/solidifier.go
@@ -541,8 +541,13 @@ func searchMissingMilestone(solidMilestoneIndex milestone.Index, startMilestoneI
 					msIndex := cachedBndl.GetBundle().GetMilestoneIndex()
 					if (msIndex > solidMilestoneIndex) && (msIndex < startMilestoneIndex) {
 						// milestone found!
-						processValidMilestone(cachedBndl.Retain()) // bundle pass +1
-						return ErrMissingMilestoneFound            // we return this as an error to stop the traverser
+						if cachedBndl.GetBundle().IsValid() && cachedBndl.GetBundle().ValidStrictSemantics() && cachedBndl.GetBundle().IsMilestone() {
+							// Force release to store milestones without caching
+							tangle.StoreMilestone(cachedBndl.GetBundle()).Release(true) // milestone +-0
+
+							processValidMilestone(cachedBndl.Retain()) // bundle pass +1
+							return ErrMissingMilestoneFound            // we return this as an error to stop the traverser
+						}
 					}
 				}
 			}

diff --git a/scripts/build_goreleaser_snapshot.sh b/scripts/build_goreleaser_snapshot.sh
@@ -6,7 +6,7 @@
 # make script executable independent of path
 cd $(dirname "$0")/../
 
-GORELEASER_IMAGE=iotmod/goreleaser-cgo-cross-compiler:1.15
+GORELEASER_IMAGE=iotmod/goreleaser-cgo-cross-compiler:1.15.5
 REPO_PATH="/build"
 
 docker pull "${GORELEASER_IMAGE}"