Adapt inx-mqtt to iota 2.0 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrvivian
force-pushed
the
feat/adapt-to-iota2.0
branch
from
acbe35c
to
549d9ca
Compare
muXxer
requested changes
Sep 19, 2023
muXxer
reviewed
Sep 19, 2023
| if err != nil { | ||
| return | ||
| } | ||
|
|
||
| s.PublishRawOnTopicIfSubscribed(topicBlocks, blk.GetData()) | ||
|
|
||
| switch payload := block.Payload.(type) { | ||
| basicBlk, isBasicBlk := block.Block.(*iotago.BasicBlock) |
There was a problem hiding this comment.
I still think it will be valuable to have a topic for validator blocks, but maybe we can add that in the future?
There was a problem hiding this comment.
You're right, I always forgot about validator blocks. 😛
Let's add that in the future.
muXxer
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.