Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update delegation creation and transition rules #1421

Merged
merged 29 commits into from
Jan 29, 2024
Merged

Update delegation creation and transition rules #1421

merged 29 commits into from
Jan 29, 2024

Conversation

Thoralf-M
Copy link
Member

Description of change

Add end_epoch delegation transition rules

Links to any relevant issues

Closes #1313

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How the change has been tested

Not tested, don't know how to test without having many other things done before

@Thoralf-M Thoralf-M force-pushed the delegation-transition-rules branch from 2e4670c to 03b4cbf Compare October 12, 2023 08:56
DaughterOfMars
DaughterOfMars reviewed Oct 12, 2023
View reviewed changes
Copy link

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this could be improved after the changes in the mana calculation PR, it's unfortunate that I'm being held up on that

thibault-martinez
thibault-martinez requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@Thoralf-M Thoralf-M force-pushed the delegation-transition-rules branch from 765baab to 36874e4 Compare October 26, 2023 13:56
@Thoralf-M Thoralf-M force-pushed the delegation-transition-rules branch from 73a842f to 896a7f4 Compare October 31, 2023 19:05
@Thoralf-M Thoralf-M force-pushed the delegation-transition-rules branch from 2c32e17 to c8bb60d Compare November 3, 2023 08:58
@Thoralf-M
Copy link
Member Author

Waiting for TIP to be updated

@Thoralf-M Thoralf-M marked this pull request as draft November 3, 2023 12:32
@Thoralf-M Thoralf-M force-pushed the delegation-transition-rules branch from bf94be7 to 5e41367 Compare November 27, 2023 13:20
@Thoralf-M Thoralf-M force-pushed the delegation-transition-rules branch from 5e41367 to 2b1d7b0 Compare January 12, 2024 14:36
@Thoralf-M Thoralf-M force-pushed the delegation-transition-rules branch from 74919e7 to acddf34 Compare January 22, 2024 10:39
@Thoralf-M Thoralf-M marked this pull request as ready for review January 22, 2024 11:06
@Thoralf-M Thoralf-M linked an issue Jan 22, 2024 that may be closed by this pull request
Add Delegation end epoch validation rule #1313
Closed
Thoralf-M and others added 24 commits January 29, 2024 09:34
@Thoralf-M
Resolve conflicts
c3684ea
@Thoralf-M
Remove epoch_start in favor of first_slot_index
8d705f7
@Thoralf-M
fmt
424284d
@Thoralf-M
Review suggestions
902a8dd
@Thoralf-M
Resolve conflicts
86987e1
@Thoralf-M
Review suggestions
9b8a713
@Thoralf-M
Cleanup
70f4e7d
@Thoralf-M
Update creation check
336238a
@Thoralf-M
Address review comments
245e998
@Thoralf-M
Use max_committable_age
a17b756
@Thoralf-M
Move things, clarify
5e3ebab
@Thoralf-M
Move bounded_slot methods to SlotCommitmentId
308c3e4
@Thoralf-M
typo
0ddfd7e
@Thoralf-M
Simplify
128ab7b
@Thoralf-M
Add genesis slot offset to slot calculations
7601b46
@Thoralf-M
Accept impl Into<SlotIndex>
6345dde
@Thoralf-M @thibault-martinez
Apply suggestions from code review
36bcab7 
Co-authored-by: Thibault Martinez <[email protected]>
@Thoralf-M
impl Into<SlotIndex> for consistency
822c670
@Thoralf-M
Align param order
c04d955
@Thoralf-M
Remove into
ab858b0
@Thoralf-M
Align registration slot calculation with TIP
22960df
@Thoralf-M
Add genesis_slot offset to range
dbae5e3
@Thoralf-M
Fmt, no_std
a7d6b1a
@Thoralf-M
Clippy
a5a80d7
@Thoralf-M Thoralf-M force-pushed the delegation-transition-rules branch from 5d0af6d to a5a80d7 Compare January 29, 2024 08:35
@thibault-martinez thibault-martinez merged commit abcdd61 into iotaledger:2.0 Jan 29, 2024
36 checks passed
@thibault-martinez thibault-martinez mentioned this pull request Jan 29, 2024
Closed
@Thoralf-M Thoralf-M deleted the delegation-transition-rules branch January 29, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars requested changes

@Alex6323 Alex6323 Alex6323 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Delegation end epoch validation rule
4 participants
@Thoralf-M @thibault-martinez @DaughterOfMars @Alex6323