mux review comments

rent.go

@@ -59,7 +59,7 @@ func (r *RentStructure) CoversMinDeposit(object NonEphemeralObject, amount BaseT
 	return minDeposit, nil
 }
 
-// MinDeposit returns the minimum rent to cover a given object.
+// MinDeposit returns the minimum deposit to cover a given object.
 func (r *RentStructure) MinDeposit(object NonEphemeralObject) BaseToken {
 	return BaseToken(r.VByteCost) * BaseToken(object.VBytes(r, nil))
 }

vm/stardust/vm_stardust.go

@@ -317,10 +317,11 @@ func accountBlockIssuerSTVF(input *vm.ChainOutputWithCreationTime, next *iotago.
 	// AccountInPotential
 	// the storage deposit does not generate potential mana, so we only use the excess base tokens to calculate the potential mana
 	var excessBaseTokensAccount iotago.BaseToken
-	if current.Amount <= rentStructure.MinDeposit(current) {
+	minDeposit := rentStructure.MinDeposit(current)
+	if current.Amount <= minDeposit {
 		excessBaseTokensAccount = 0
 	} else {
-		excessBaseTokensAccount = current.Amount - rentStructure.MinDeposit(current)
+		excessBaseTokensAccount = current.Amount - minDeposit
 	}
 	manaPotentialAccount, err := manaDecayProvider.PotentialManaWithDecay(excessBaseTokensAccount, input.CreationTime, vmParams.WorkingSet.Tx.Essence.CreationTime)
 	if err != nil {

vm/vm.go

@@ -140,10 +140,11 @@ func TotalManaIn(manaDecayProvider *iotago.ManaDecayProvider, rentStructure *iot
 
 		// potential Mana
 		// the storage deposit does not generate potential mana, so we only use the excess base tokens to calculate the potential mana
-		if input.Output.BaseTokenAmount() <= rentStructure.MinDeposit(input.Output) {
+		minDeposit := rentStructure.MinDeposit(input.Output)
+		if input.Output.BaseTokenAmount() <= minDeposit {
 			continue
 		}
-		excessBaseTokens := input.Output.BaseTokenAmount() - rentStructure.MinDeposit(input.Output)
+		excessBaseTokens := input.Output.BaseTokenAmount() - minDeposit
 		manaPotential, err := manaDecayProvider.PotentialManaWithDecay(excessBaseTokens, input.CreationTime, txCreationTime)
 		if err != nil {
 			return 0, ierrors.Wrapf(err, "input %s potential mana calculation failed", outputID)