Changes to add Account support #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go into tmp-accounts
The field must be second last with the nonce being last in order for the `contentHashFromBlockBytes` to work correctly. Also make the calculation of `SlotIdentifierLength` slightly more clear by using the size of a `uint64` rather than `int64`.
alexsporn
reviewed
Jun 20, 2023
| @@ -99,6 +101,12 @@ type ProtocolParameters struct { | |||
| GenesisUnixTimestamp uint32 `serix:"6,mapKey=genesisUnixTimestamp"` | |||
| // SlotDurationInSeconds defines the duration of each slot in seconds. | |||
| SlotDurationInSeconds uint8 `serix:"7,mapKey=slotDurationInSeconds"` | |||
| // ManaGenerationRate is the amount of potential Mana generated by 1 IOTA in 1 slot. | |||
| ManaGenerationRate uint8 //`serix:"8,mapKey=manaGenerationRate"` | |||
There was a problem hiding this comment.
why are the serix tags commented out?
alexsporn
reviewed
Jun 20, 2023
| @@ -47,6 +47,8 @@ func LatestAPI(protoParams *ProtocolParameters) API { | |||
| } | |||
|
|
|||
| // calls the internally instantiated API to encode the given object. | |||
| // | |||
| //nolint:unparam | |||
alexsporn
reviewed
Jun 20, 2023
| @@ -86,8 +86,9 @@ func TestProtocolParametersJSONMarshalling(t *testing.T) { | |||
| TokenSupply: 1234567890987654321, | |||
| GenesisUnixTimestamp: 1681373293, | |||
| SlotDurationInSeconds: 10, | |||
| MaxCommitableAge: 10, | |||
There was a problem hiding this comment.
Add the new mana values to this test
alexsporn
reviewed
Jun 20, 2023
alexsporn
reviewed
Jun 20, 2023
alexsporn
reviewed
Jun 20, 2023
alexsporn
reviewed
Jun 20, 2023
| } | ||
|
|
||
| func (s *BlockIssuerFeature) VBytes(rentStruct *RentStructure, _ VBytesFunc) VBytes { | ||
| // TODO: add factor for block issuer keys (higher than regular keys factor). |
There was a problem hiding this comment.
Tracked in iotaledger/iota-core#137
alexsporn
reviewed
Jun 20, 2023
alexsporn
reviewed
Jun 20, 2023
alexsporn
reviewed
Jun 20, 2023
alexsporn
reviewed
Jun 20, 2023
| @@ -403,6 +432,22 @@ func ExecFuncSenderUnlocked() ExecFunc { | |||
| } | |||
| } | |||
|
|
|||
| // ExecFuncBalancedMana validates that Mana is balanced from the input/output side. | |||
| // TODO: Return Mana according to StorageDepositReturnUnlockCondition(s)? | |||
alexsporn
reviewed
Jun 20, 2023
alexsporn
reviewed
Jun 20, 2023
alexsporn
force-pushed
the
serix-iota-core-accounts
branch
from
5251c62 to
537f7d9
Compare
alexsporn
force-pushed
the
serix-iota-core-accounts
branch
from
537f7d9 to
a483caf
Compare
alexsporn
force-pushed
the
serix-iota-core-accounts
branch
from
a09f9d7 to
2e18e83
Compare
cyberphysic4l
force-pushed
the
serix-iota-core-accounts
branch
from
7527feb to
328934f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR introduces a large number of changes that add support for using AccountOutput in a transaction, in place of AliasOutput.
It also extends VM to support Transaction validation when creating, destroying or modifying an AccountOutput.
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Implemented unit tests.
This code is also used in iota-core software which uses it in it's own test cases.
Make sure to provide instructions for the maintainer as well as any relevant configurations.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.