Don't generate Mana from storage deposit #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippGackstatter
approved these changes
Aug 2, 2023
muXxer
requested changes
Aug 2, 2023
muXxer
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the potential Mana for outputs to only include tokens in excess of the minimum storage deposit, i.e., the storage deposit does not generate Mana, which makes this serve a rent payment (in Mana) for storing the output.
This PR also includes some renaming around deposits and rent. Deposit not strictly refers to the minimum storage deposit required for the object, while base token amount or amount refers to the total amount of base tokens on the object. Rent is payed in Mana, so the storage deposit itself is not "rent", but rather a deposit, and rent is the Mana that the base tokens of the storage deposit would otherwise generate if it were not a storage deposit.