Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce VBytes factor for block issuer keys and staking. #471

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

piotrm50
Copy link
Contributor

@piotrm50 piotrm50 commented Aug 2, 2023

Description of change

Introduce VBytes factor for block issuer keys and staking.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests using ginkgo that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

rent.go Outdated
// VByteCostFactorBlockIssuerKeys defines the multiplier for block issuer public keys.
VByteCostFactorBlockIssuerKeys VByteCostFactor = 10
// VByteCostFactorStakingFeature defines the multiplier for account output's staking feature.
VByteCostFactorStakingFeature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove this constants because they should always come from the protocol parameters

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@piotrm50 piotrm50 merged commit 7e29753 into serix-iota-core Aug 4, 2023
4 checks passed
@piotrm50 piotrm50 deleted the feat/vbytes-factor-issuer-validator branch August 4, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Higher dust deposit factor for BIF Keys
3 participants