Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheduler params and max block work and activate workscore #479

Merged
merged 24 commits into from
Aug 17, 2023

Conversation

cyberphysic4l
Copy link
Contributor

@cyberphysic4l cyberphysic4l commented Aug 10, 2023

companion PR for iotaledger/iota-core#283

@cyberphysic4l cyberphysic4l marked this pull request as draft August 10, 2023 15:50
@cyberphysic4l cyberphysic4l marked this pull request as ready for review August 14, 2023 16:46
@cyberphysic4l
Copy link
Contributor Author

Now that Block interface is a Sizer, there is a failing test related to deserialisation: the serialiser yields a different number of bytes that the Size() method for blocks. Off by 7 for basic blocks and off by 3 for validation blocks.

api_v3_protocol_parameters.go Show resolved Hide resolved
block.go Show resolved Hide resolved
block.go Show resolved Hide resolved
feat.go Show resolved Hide resolved
feat_blockissuer.go Show resolved Hide resolved
@cyberphysic4l cyberphysic4l merged commit 87dc40e into serix-iota-core Aug 17, 2023
4 checks passed
@cyberphysic4l cyberphysic4l deleted the feat/scheduler-params branch August 17, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants