Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Governor control the Block Issuer Feature #483

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

PhilippGackstatter
Copy link
Contributor

Description of change

Change permissions for governor and state controller with respect to the Block Issuer Feature (BIF) and Staking Feature (SF).

  • The BIF can be modified by the governor.
  • The SF can be modified by state controller.

Additionally, handle other cases:

  • Check for negative BIC (= account locked) more generally, even when BIF is untouched in the transaction. Introduce dedicated error types for these cases making it easier to test for them and those tests more precise.
  • Staking & block issuer feature creation during regular account transitions. Previously this was only handled during account genesis itself.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Added various STVF tests and adapted existing ones.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests using ginkgo that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

- Block Issuer Feature can be modified by governor
- Staking Feature can be modified by state controller
- Check for negative BIC more generally
- Handle staking & block issuer feature genesis
during regular account transitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants