Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Issuer Keys interface #489

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Conversation

PhilippGackstatter
Copy link
Contributor

Description of change

Add a Block Issuer Keys interface that is implemented by Ed25519 keys. This is so we can add a type prefix to the serialized public key and are more future proof.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Existing tests run successfully. Manually checked the produced JSON has the expected type prefix.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests using ginkgo that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@muXxer muXxer merged commit 46cad51 into serix-iota-core Aug 29, 2023
@muXxer muXxer deleted the block-issuer-keys-interface branch August 29, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants