Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retainer data cleanup and documentation #696

Merged
merged 20 commits into from
Mar 7, 2024
Merged

Retainer data cleanup and documentation #696

merged 20 commits into from
Mar 7, 2024

Conversation

cyberphysic4l
Copy link
Contributor

@cyberphysic4l cyberphysic4l commented Feb 21, 2024

Rename, restructure and document the various block and transaction states to be stored in the retainer.

  • BlockStateRejected renamed to align with our usual terminology, now called BlockStateOrphaned is returned when a the block's slot is committed, but the block is not yet accepted (it is therefore orphaned).
  • Document meaning of the block and transaction states more clearly.

To be merged alongside iotaledger/iota-core#766
closes iotaledger/iota-core#723

@cyberphysic4l cyberphysic4l changed the title rename BlockStateRejected to BlockStateOrphaned Retainer data cleanup and documentation Feb 22, 2024
api/core.go Outdated Show resolved Hide resolved
@muXxer muXxer merged commit a87b511 into develop Mar 7, 2024
4 checks passed
@muXxer muXxer deleted the feat/blockstate branch March 7, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clearly define the meaning of the different flags (accepted, committed, finalized etc)
4 participants