Make some Commitment Input checks syntactical #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Make some Commitment Input checks syntactical per the reasoning in #693.
See the TIPs for details on the updated rules:
Fixes #693.
The checks that were previously semantic were made panics since we have to be able to assume at the semantic validation stage that the syntactic stage was passed successfully. Exception to this: Newly added Block Issuer Features still return an error, because we would have to specifically add a panic and make the code less nicely structured, so it seems fine to not panic.
How the change has been tested
New syntactical function covered 100% by test
TestCommitmentInputSyntacticalValidation.