feat(move/examples): implementation of kiosk marketplace extension using kiosk rules #4156
+857
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… separately from the marketplace extension and added some mock items for marketplace operations
miker83z
requested changes
Nov 26, 2024
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
docs/examples/move/nft_marketplace/sources/item_for_market.move
Outdated
Show resolved
Hide resolved
Co-authored-by: Mirko Zichichi <[email protected]>
|
✅ Vercel Preview Deployment is ready! |
|
✅ Vercel Preview Deployment is ready! |
|
✅ Vercel Preview Deployment is ready! |
miker83z
reviewed
Nov 27, 2024
docs/examples/move/nft_marketplace/sources/nft_marketplace.move
Outdated
Show resolved
Hide resolved
miker83z
reviewed
Nov 27, 2024
Co-authored-by: Mirko Zichichi <[email protected]>
Co-authored-by: Mirko Zichichi <[email protected]>
|
✅ Vercel Preview Deployment is ready! |
Dkwcs
changed the title
miker83z
reviewed
Nov 27, 2024
Comment on lines
+63
to
+77
| assert!(kiosk_extension::is_installed<Marketplace>(kiosk), EExtensionNotInstalled); | ||
| let ItemPrice { price } = take_from_bag<T, Listed>(kiosk, Listed { id: item_id }); | ||
|
|
||
| let payment_amount_value = payment.value(); | ||
| let coin_price = payment.split(price, ctx); | ||
|
|
||
| let (item, mut transfer_request) = purchase(kiosk, item_id, coin_price); | ||
| if (policy.has_rule<T, RoyaltyRule>()) { | ||
| let royalties_value = royalty_rule::fee_amount(policy, price); | ||
| assert!(payment_amount_value == price + royalties_value, EWrongPaymentRoyalties); | ||
| royalty_rule::pay(policy, &mut transfer_request, payment); | ||
| } else { | ||
| payment.destroy_zero(); | ||
| }; | ||
| transfer_policy::confirm_request(policy, transfer_request); |
There was a problem hiding this comment.
Suggested change
| assert!(kiosk_extension::is_installed<Marketplace>(kiosk), EExtensionNotInstalled); | |
| let ItemPrice { price } = take_from_bag<T, Listed>(kiosk, Listed { id: item_id }); | |
| let payment_amount_value = payment.value(); | |
| let coin_price = payment.split(price, ctx); | |
| let (item, mut transfer_request) = purchase(kiosk, item_id, coin_price); | |
| if (policy.has_rule<T, RoyaltyRule>()) { | |
| let royalties_value = royalty_rule::fee_amount(policy, price); | |
| assert!(payment_amount_value == price + royalties_value, EWrongPaymentRoyalties); | |
| royalty_rule::pay(policy, &mut transfer_request, payment); | |
| } else { | |
| payment.destroy_zero(); | |
| }; | |
| transfer_policy::confirm_request(policy, transfer_request); | |
| assert!(kiosk_extension::is_installed<Marketplace>(kiosk), EExtensionNotInstalled); | |
| // Get item price | |
| let ItemPrice { price } = take_from_bag<T, Listed>(kiosk, Listed { id: item_id }); | |
| // Compute the value of the coin in input | |
| let payment_amount_value = payment.value(); | |
| // Prepare the payment coin for the purchase (if no royalties are present then the | |
| // remaining balance will be 0 after this operation) | |
| let coin_price = payment.split(price, ctx); | |
| // Purchase and create the transfer request | |
| let (item, mut transfer_request) = purchase(kiosk, item_id, coin_price); | |
| // If the royalty is present, then update the request with a royalty payment | |
| if (policy.has_rule<T, RoyaltyRule>()) { | |
| let royalties_value = royalty_rule::fee_amount(policy, price); | |
| assert!(payment_amount_value == price + royalties_value, EWrongPaymentRoyalties); | |
| royalty_rule::pay(policy, &mut transfer_request, payment); | |
| } else { | |
| // Else clean the input coin (if the input payment amount is not exact, this will fail) | |
| payment.destroy_zero(); | |
| }; | |
| // Confirm the request | |
| transfer_policy::confirm_request(policy, transfer_request); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
New Kiosk extensions have been added in order to demonstrate practical usage of some Kiosk features(extensions, rules, transfer policies).
Links to any relevant issues
Fix #3997 .
Type of change
How the change has been tested
Read https://github.com/iotaledger/iota/pull/4156/files#diff-ed4b688332b92ef7cc237545e28cac0a73f64d2e509737d8e95cc72a6b82831d