Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs) : fix css for CTF component. #4208

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(docs) : fix css for CTF component. #4208

wants to merge 2 commits into from

Conversation

vivekjain23
Copy link
Contributor

Description of change

This PR brings up the changes to fix the styles of the CTF component.

Links to any relevant issues

fixes #4131.

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Documentation Fix.

How the change has been tested

Changes were built locally.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@vivekjain23 vivekjain23 added documentation Improvements or additions to documentation dx-documentation For TW or documentation related issues. dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx. labels Nov 25, 2024
@vivekjain23 vivekjain23 self-assigned this Nov 25, 2024
@vivekjain23 vivekjain23 requested a review from a team as a code owner November 25, 2024 13:36
@github-actions GitHub Actions
Copy link

✅ Vercel Preview Deployment is ready!

View Preview

@github-actions GitHub Actions
Copy link

✅ Vercel Preview Deployment is ready!

View Preview

salaheldinsoliman
salaheldinsoliman approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@salaheldinsoliman salaheldinsoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks nice, thanks Vivek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salaheldinsoliman salaheldinsoliman salaheldinsoliman approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@vivekjain23 vivekjain23

Labels
documentation Improvements or additions to documentation dx-documentation For TW or documentation related issues. dx-improvement Mainly for DX team itself to track issues with features/fixes that improve dx.
Projects
Developer Experience
Status: Under Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve style of submit button of CTF challenges
2 participants
@vivekjain23 @salaheldinsoliman