Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to SD-JWT v12 & API rework #14
base: main
Are you sure you want to change the base?
Upgrade to SD-JWT v12 & API rework #14
Changes from 14 commits
051c5b1
2862517
dd67e3a
8338101
5973fa2
8cecbaf
d87a37d
e70dc9a
65d58b2
cc13221
b4d69e6
0c1364e
8ba37a1
dacd94f
5cdefd9
97095d9
9d3431f
38013b0
f730806
a492c48
1c387e7
11d0c85
a343b7a
1f37bbe
ebc05f6
9601f3f
dd24522
f2ad25f
3bebdc0
0300fc5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nitpicking)
Should we use align the example calls with the example output to keep them talking about the same data? E.g. the example calls only hide
/phone/0
but the example shows more phone entries as hidden, and the_sd
array has 7 entries, though it should have 6?We could also re-use the example code for the readme and use output from it, might be easier to keep in sync. ^^