[API] increase api listener limit #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderZhi
approved these changes
Aug 25, 2024
dustinxie
reviewed
Aug 28, 2024
| return status.Error(codes.Internal, err.Error()) | ||
| } | ||
| err := <-errChan | ||
| err = <-errChan | ||
| chainListener.RemoveResponder(id) |
There was a problem hiding this comment.
receiving the errChan means the end of the StreamBlocks
dustinxie
reviewed
Aug 28, 2024
| chainListener := svr.coreService.ChainListener() | ||
| streamID, err := chainListener.AddResponder(NewWeb3BlockListener(writer.Write)) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| ctx.AddListener(streamID) |
There was a problem hiding this comment.
the removing should after wss disconnected, not here
dustinxie
reviewed
Aug 29, 2024
| for _, id := range sc.ListenerIDs() { | ||
| wsSvr.coreService.ChainListener().RemoveResponder(id) | ||
| } | ||
| } | ||
| for { | ||
| select { | ||
| case <-ctx.Done(): |
There was a problem hiding this comment.
here should also call cancel to clean up (remove all responder)?
dustinxie
approved these changes
Aug 29, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Temporarily relax #4373 , increase global listen limits to 5000 from 500
Ultimately, the api
eth_subscribeandeth_unsubscribeshould only take effect for websockets, and related listeners should be cleaned up after the connection is disconnected. The limitations can also be revised to apply to the number of listeners per connection.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: