-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multipackage for managing CI/CD scripts #81
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand most code is auto-generated, but isn't there a way to still keep most of these code on a package that gets included by the auto-generated code?
@dkarchmer It definitely could be. The question is just philosophical. Do you want the build/release scripts to depend on My thinking is that we don't want anything related to build/release to depend on what version of The downside though is that you have these large diffs when you install and potentially when you update as well. Thoughts? @mattrunchey Do you have a perspective here? |
@timburke I see the argument. As you say, it is a tradeoff.
inside the configuration file itself, ensuring that if I update the package, I get an error if it falls outside the allowed versions. But in my opinion, if I am relying on a framework (and I want to one day be able to do an "update"), I need to come up with a way to manage my dependencies. A good requitements.txt should be enough IMO. Yes, something can change, but at least for Python, things tend to be fairly stable, and if you have good testing, I can trust the framework is protecting me (it is not like we cannot break the build in so many other ways). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems this review was stuck some time ago
This PR ports
iotile_analytics
over to usingmultipackage
for managing its CI/CD scripts.This PR was the result of running:
Then initializing the repository with:
Then updating the
.multipackage/components.txt
file with the names of the packages in the repo (This is what used to bescripts/components.py
:Finally, all of the build scripts were installed using:
You can run
multipackage update
at any point in the future to update your build scripts to the latest version.