Fix ReportPostPayoad to accept a label string #142
Conversation
This will allow caller to pass a label when generating an analytics report
|
closes #141 |
| @@ -55,6 +55,9 @@ | |||
| "karma-sourcemap-loader": "0.3.7", | |||
| "karma-spec-reporter": "0.0.31", | |||
| "karma-webpack": "3.0.0", | |||
| "lodash": "^4.17.11", | |||
| "mime": "^2.4.0", | |||
| "parsejson": "0.0.3", | |||
There was a problem hiding this comment.
Do we use these libraries?
There was a problem hiding this comment.
We don't use them directly, but I am trying to fix the github security warning alerts. In reality, the real fix is to upgrade the packages we do use, but that requires more time I can put on it right now:
There was a problem hiding this comment.
oh ok! PR looks good then!
There was a problem hiding this comment.
could you remove these 2 lines of code? they use the old version of observable and break the new library
https://github.com/iotile/ng-iotile-cloud/blob/master/src/cloud.service.ts#L6
https://github.com/iotile/ng-iotile-cloud/blob/master/src/cloud.service.ts#L7
There was a problem hiding this comment.
What do you mean be remove? They are used. How do I remove them? Can I just upgrade the rs library?
There was a problem hiding this comment.
If you just delete those two lines of code, rs library has already been updated and ForkJoin has already been imported on line 5 and of is not being used.
These two lines don't break the webapp because it includes the package rxjs-compat for backward compatibility, but that package is not included in the new library
Which can break caller libraries.
This will allow caller to pass a label when generating an analytics report.
Version 0.26.0