no explicit username token registration owner (#1079)

This change is a reverse of modification introduced in 0.23.0 release.
Do not allow to explicitely specify a new token owner. Rely on the
`AnySigner` result.
The above was an improvement. We deprecate `x/username` pacakge and do
not want to introduce more work, even if those are fixing issues.

resolve #1066

CHANGELOG.md

@@ -22,6 +22,11 @@ Breaking changes
 - `orm.WithIndex` supports multiple indexer types,
 - `orm.NewIndex` function was removed,
 
+Breaking changes
+
+- `x/username`: rollback of registration change introduced in 0.23.0. When
+  registering a token, do not allow to explicitly specify the new token owner.
+
 
 ## 0.23.0
 

cmd/bnscli/clitests/register_username.test

@@ -5,7 +5,6 @@ set -e
 bnscli register-username \
 		-name alice \
 		-bc fairycoin \
-		-owner 92066456B2BE7F1934624087D98C203A87F7752C \
 		-addr 46722031342e204a756e2031303a35363a3337204345535420323031390a \
 	| bnscli view
 

cmd/bnscli/clitests/register_username.test.gold

@@ -10,8 +10,7 @@
 					"blockchain_id": "fairycoin",
 					"address": "46722031342e204a756e2031303a35363a3337204345535420323031390a"
 				}
-			],
-			"owner": "92066456B2BE7F1934624087D98C203A87F7752C"
+			]
 		}
 	}
 }

cmd/bnscli/cmd_username.go

@@ -24,7 +24,6 @@ Create a transaction for registering a username.
 	}
 	var (
 		nameFl       = fl.String("name", "", "Name part of the username. For example 'alice'")
-		ownerFl      = flAddress(fl, "owner", "", "An address that the newly registered token will belong to. Transaction does not have to be signed by this address.")
 		namespaceFl  = fl.String("ns", "iov", "Namespace (domain) part of the username. For example 'iov'")
 		blockchainFl = fl.String("bc", "", "Blockchain network ID.")
 		addressFl    = fl.String("addr", "", "String representation of the blochain address on this network.")
@@ -47,7 +46,6 @@ Create a transaction for registering a username.
 		Metadata: &weave.Metadata{Schema: 1},
 		Username: *nameFl + "*" + *namespaceFl,
 		Targets:  targets,
-		Owner:    *ownerFl,
 	}
 	if err := msg.Validate(); err != nil {
 		return fmt.Errorf("given data produce an invalid message: %s", err)

cmd/bnsd/x/username/codec.proto

@@ -50,8 +50,6 @@ message RegisterTokenMsg {
   string username = 2;
   // Targets is a blockchain address list that this token should point to.
   repeated BlockchainAddress targets = 3 [(gogoproto.nullable) = false];
-  // Owner is the address that the newly created token will belong to.
-  bytes owner = 4 [(gogoproto.casttype) = "github.com/iov-one/weave.Address"];
 }
 
 // TransferTokenMsg is a request to transfer an ownership of a token. The

cmd/bnsd/x/username/handlers.go

@@ -44,15 +44,9 @@ func (h *registerTokenHandler) Deliver(ctx weave.Context, db weave.KVStore, tx w
 		return nil, err
 	}
 
-	var owner weave.Address
-	if len(msg.Owner) != 0 {
-		// Permission is not required.
-		owner = msg.Owner
-	} else {
-		owner = x.AnySigner(ctx, h.auth).Address()
-		if len(owner) == 0 {
-			return nil, errors.Wrap(errors.ErrUnauthorized, "message must be signed")
-		}
+	owner := x.AnySigner(ctx, h.auth).Address()
+	if len(owner) == 0 {
+		return nil, errors.Wrap(errors.ErrUnauthorized, "message must be signed")
 	}
 
 	token := Token{

cmd/bnsd/x/username/msg.go

@@ -35,13 +35,6 @@ func (m *RegisterTokenMsg) Validate() error {
 
 	// Username should but cannot be validated here.
 
-	// Owner field is optional.
-	if len(m.Owner) != 0 {
-		if err := m.Owner.Validate(); err != nil {
-			return errors.Wrap(err, "owner")
-		}
-	}
-
 	if err := validateTargets(m.Targets); err != nil {
 		return errors.Wrap(err, "targets")
 	}

docs/proto/index.html

@@ -2979,13 +2979,6 @@ <h3 id="username.RegisterTokenMsg">RegisterTokenMsg</h3>
                   <td><p>Targets is a blockchain address list that this token should point to. </p></td>
                 </tr>
 
-                <tr>
-                  <td>owner</td>
-                  <td><a href="#bytes">bytes</a></td>
-                  <td></td>
-                  <td><p>Owner is the address that the newly created token will belong to. </p></td>
-                </tr>
-
             </tbody>
           </table>
 

spec/gogo/cmd/bnsd/x/username/codec.proto

@@ -50,8 +50,6 @@ message RegisterTokenMsg {
   string username = 2;
   // Targets is a blockchain address list that this token should point to.
   repeated BlockchainAddress targets = 3 [(gogoproto.nullable) = false];
-  // Owner is the address that the newly created token will belong to.
-  bytes owner = 4 [(gogoproto.casttype) = "github.com/iov-one/weave.Address"];
 }
 
 // TransferTokenMsg is a request to transfer an ownership of a token. The

spec/proto/cmd/bnsd/x/username/codec.proto

@@ -49,8 +49,6 @@ message RegisterTokenMsg {
   string username = 2;
   // Targets is a blockchain address list that this token should point to.
   repeated BlockchainAddress targets = 3 ;
-  // Owner is the address that the newly created token will belong to.
-  bytes owner = 4 ;
 }
 
 // TransferTokenMsg is a request to transfer an ownership of a token. The