More External Project Configuration Updates #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hawkinsw
commented
Dec 15, 2023
hawkinsw
commented
- Make sure that tests that require external packages do not try to build when the user has opted out of external packages.
- Integrate git submodules with external projects (CMake) for the best of both worlds!
1. Make sure that tests that require external packages do not try to build when the user has opted out of external packages. 2. Integrate git submodules with external projects (CMake) for the best of both worlds! Signed-off-by: Will Hawkins <[email protected]>
hawkinsw
force-pushed
the
external_cmake_additional_configuration
branch
from
65649f5 to
fd99d5d
Compare
Alan-Jowett
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.