[ovs offload] script name change ovs_offload_lnv.py to ovs_offload_lnw.py #2
Conversation
|
Updated the README with suggested change . |
naveenashok211
force-pushed
the
main
branch
from
62a1902 to
282d54d
Compare
ovs_offload/README.md
Outdated
|
|
||
| ## Test Environment Setup: | ||
| ## Test Environment Setup | ||
|
|
||
| - Before running script check if ssh as a root user is enabled and root user password is setup for ssh. |
There was a problem hiding this comment.
| - Before running script check if ssh as a root user is enabled and root user password is setup for ssh. | |
| Before running script check if ssh as a root user is enabled and root user password is set up for ssh. |
-
Bullets are used to form an unordered list. There's only one item here -- a sentence that sets up an example -- so you don't use a bullet.
-
This sequence of words doesn't make sense. Please rewrite it. Perhaps you mean:
Before running the script, make sure that
/etc/ssh/sshd_configcontains the linePermitRootLogin yes
-
The
bashcommand example doesn't help. I would recommend deleting it and focusing instead on describing clearly what you want the customer to accomplish.
There was a problem hiding this comment.
Addressed this in the latest commit .
| @@ -563,7 +561,7 @@ def build_p4rt_config(vf_list=[], acc_pr_list=[],vm_ip_list=[], host_idpf_intf=' | |||
|
|
|||
| def build_args(): | |||
| # Create the top-level parser | |||
| parser = argparse.ArgumentParser(description='Run Linux networking with OVS Offload') | |||
| parser = argparse.ArgumentParser(description='Run Linux networking V2 with OVS Offload') | |||
There was a problem hiding this comment.
We've dropped support for LNW V2.
There was a problem hiding this comment.
We have 3 versions of the script to support the OVS offload recipe on all releases from 1.4 to 1.7 as we had customers using the older versions like 1.4 for the POC hence I have retained the 3 versions , but we can remove it in future once customers move to a release 1.7 and above
ovs_offload_lnw.py : (P4:fxp-net_linux-networking.p4, IPU SDK Release >= 1.7.0)
ovs_offload_lnw_v3.py : (P4:fxp-net_linux-networking_v3.p4, IPU SDK Release 1.6.0, 1.6.1)
ovs_offload_lnw_v2.py: (P4:fxp-net_linux-networking_v2.p4, IPU SDK Release 1.4.0)
…w.py Signed-off-by: Naveen Ashok <[email protected]>
Signed-off-by: Naveen Ashok <[email protected]>
Signed-off-by: Naveen Ashok <[email protected]>
Signed-off-by: Naveen Ashok <[email protected]>
Signed-off-by: Naveen Ashok <[email protected]>
Signed-off-by: Naveen Ashok <[email protected]>
Co-authored-by: Derek G Foster <[email protected]> Signed-off-by: Naveen Ashok <[email protected]>
naveenashok211
force-pushed
the
main
branch
from
d319e3f to
ad5ea46
Compare
Signed-off-by: Naveen Ashok <[email protected]>
Pull changes from ipdk-io main to fork
Script names updated to
ovs_offload_lnv.py -> ovs_offload_lnw.py
ovs_offload_lnv2.py -> ovs_offload_lnw_v2.py
ovs_offload_lnv3.py -> ovs_offload_lnw_v3.py
The README is updated with the name change