Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues flagged by Bandit #4

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Address issues flagged by Bandit #4

merged 1 commit into from
Sep 10, 2024

Conversation

ffoulkes
Copy link
Collaborator

@ffoulkes ffoulkes commented Sep 10, 2024 •
edited
Loading

Changed if host_password == '' to if len(host_password) == 0 to address a complaint about hard-wired passwords.

naveenashok211
naveenashok211 approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@naveenashok211 naveenashok211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, thanks for adding them

@ffoulkes ffoulkes merged commit 4fa5da7 into main Sep 10, 2024
4 checks passed
@ffoulkes ffoulkes deleted the bandit-fixes branch September 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenashok211 naveenashok211 naveenashok211 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffoulkes @naveenashok211