Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename target_cc_library() to krnlmon_cc_library() #118

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Rename target_cc_library() to krnlmon_cc_library() #118

merged 2 commits into from
Apr 9, 2024

Conversation

ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Apr 9, 2024

No description provided.

@ffoulkes ffoulkes added minor effort Minimal effort required bazel Affects Bazel build system labels Apr 9, 2024
@ffoulkes ffoulkes requested a review from aashishkuma April 9, 2024 00:26
5abeel
5abeel approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nupuruttarwar
nupuruttarwar approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@nupuruttarwar nupuruttarwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit 2ad8d83 into main Apr 9, 2024
4 checks passed
@ffoulkes ffoulkes deleted the krnlmon_cc_library branch April 9, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5abeel 5abeel 5abeel approved these changes

@nupuruttarwar nupuruttarwar nupuruttarwar approved these changes

@aashishkuma aashishkuma Awaiting requested review from aashishkuma

@n-sandeep n-sandeep Awaiting requested review from n-sandeep n-sandeep is a code owner

@vsureshkumarp vsureshkumarp Awaiting requested review from vsureshkumarp vsureshkumarp is a code owner

Assignees
No one assigned
Labels
bazel Affects Bazel build system minor effort Minimal effort required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffoulkes @nupuruttarwar @5abeel