Stepwise refactoring of LNW definitions #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracted the LNWv2 and LNWv3 NEXTHOP_TABLE and ECMP_NEXTHOP_TABLE definitions into individual header files. Signed-off-by: Derek Foster <[email protected]>
- Extracted the LNWv3 NEIGHBOR_MOD_TABLE definitions into a separate header file. Signed-off-by: Derek Foster <[email protected]>
- As a result of the preceding extractions, the LNWv2 and LNWv3 versions of switch_pd_p4_name_routing.h are identical. Moved the header file to the switchapi/es2k folder. Signed-off-by: Derek Foster <[email protected]>
- Removed redundant definitions from switch_pd_p4_name_mapping.h. They are now defined in switch_pd_p4_name_routing.h. Signed-off-by: Derek Foster <[email protected]>
Signed-off-by: Derek Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR
Steps 2-5 of the refactoring process.