Remove Linux Networking v2 from krnlmon codebase #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sabeel Ansari <[email protected]>
5abeel
requested review from
ffoulkes,
n-sandeep and
vsureshkumarp
as code owners
ffoulkes
reviewed
Jun 25, 2024
There was a problem hiding this comment.
- PR Remove //flags:lnw_version from bazel build #149 (against this PR) updates the Bazel build. It also fixes a conditional in one of the C files.
- You will also need to remove LNW version support from ovs-p4rt:
dfoster@dgfoster-mobl1:~/work/latest$ find ovs-p4rt/ -name '*.cc' -o -name '*.h' | xargs grep LNW_
ovs-p4rt/sidecar/ovsp4rt.cc:#ifdef LNW_V2
ovs-p4rt/sidecar/ovsp4rt.cc:#endif // LNW_V2
ovs-p4rt/sidecar/ovsp4rt.cc:#ifdef LNW_V2
ovs-p4rt/sidecar/ovsp4rt.cc:#ifdef LNW_V2
ovs-p4rt/sidecar/ovsp4rt.cc:#ifdef LNW_V2
ovs-p4rt/sidecar/ovsp4rt.cc:#ifdef LNW_V2
And the networking-recipe buildsystem:
dfoster@dgfoster-mobl1:~/work/latest$ find -name CMakeLists.txt -o -name '*.cmake' | xargs grep Lnw
./CMakeLists.txt:include(LnwVersion)
./cmake/LnwVersion.cmake:# cmake/LnwVersion.cmake
./krnlmon/krnlmon/cmake/standalone.cmake:include(LnwVersion)
./build/CMakeFiles/Makefile.cmake: "../cmake/LnwVersion.cmake"
And these script files:
dfoster@dgfoster-mobl1:~/work/latest$ find -name '*.sh' | xargs grep lnw
./make-all.sh: echo " --lnw-version=VER Linux networking version [${_LNW_VERSION}]"
./make-all.sh:LONGOPTS=${LONGOPTS},cxx-std:,jobs:,lnw-version:,staging:,target:
./make-all.sh: --lnw-version)
./scripts/es2k/config-cross-recipe.sh: echo " --lnw-version=VER Linux networking version [${_LNW_VERSION}]"
./scripts/es2k/config-cross-recipe.sh:LONGOPTS=build:,deps:,hostdeps:,lnw-version:,ovs:,prefix:,sde:,toolchain:
./scripts/es2k/config-cross-recipe.sh: --lnw-version)
dfoster@dgfoster-mobl1:~/work/latest$ find -name '*.sh' | xargs grep LNW_
./make-all.sh:_LNW_VERSION=
./make-all.sh: echo " --lnw-version=VER Linux networking version [${_LNW_VERSION}]"
./make-all.sh: [ -n "${_LNW_VERSION}" ] && echo "${_LNW_VERSION:2}"
./make-all.sh: ${_LNW_VERSION} \
./make-all.sh: _LNW_VERSION=$2
./make-all.sh:[ -n "${_LNW_VERSION}" ] && _LNW_VERSION="-DLNW_VERSION=${_LNW_VERSION}"
./scripts/es2k/config-cross-recipe.sh: echo " --lnw-version=VER Linux networking version [${_LNW_VERSION}]"
./scripts/es2k/config-cross-recipe.sh: [ -n "${_LNW_VERSION}" ] && echo "${_LNW_VERSION:2}"
./scripts/es2k/config-cross-recipe.sh: _LNW_VERSION=$2
./scripts/es2k/config-cross-recipe.sh:[ -n "${_LNW_VERSION}" ] && _LNW_VERSION="-DLNW_VERSION=${_LNW_VERSION}"
./scripts/es2k/config-cross-recipe.sh: ${_LNW_VERSION} \
And these document files:
dfoster@dgfoster-mobl1:~/work/latest$ find ../p4cp-userguide/ -name '*.md' -o -name '*.rst' | xargs grep lnw_
../p4cp-userguide/docs/scripts/make-all.rst:``--lnw_version=VERSION``
../p4cp-userguide/docs/scripts/config-cross-recipe.rst:``--lnw_version=VERSION``
Signed-off-by: Derek Foster <[email protected]>
Signed-off-by: Sabeel Ansari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all the LNW_v2 from the krnlmon codebase since LNW_v2 is not supported anymore.
This PR removes code support. A subsequent PR will cleanup all build related support (cmake and bazel)