Fix error in standalone cmake build #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The krnlmon_unit_tests workflow fails with the following message:
CMake Error at CMakeLists.txt:69 (set_install_rpath):
Unknown CMake command "set_install_rpath".
This is because set_install_rpath() is defined in the top-level
networking-recipe CMakeLists.txt file, which is not executed in
standalone build mode.
Addressed the issue by moving the function definition to its own
file (SetInstallPath.cmake) and including it from standalone.cmake
in the krnlmon build.
Note that this commit is dependent on a corresponding commit in
the networking-recipe repository.
Signed-off-by: Derek Foster <[email protected]>
ffoulkes
requested review from
5abeel,
n-sandeep and
vsureshkumarp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The krnlmon_unit_tests workflow fails with the following message:
CMake Error at CMakeLists.txt:69 (set_install_rpath):
Unknown CMake command "set_install_rpath".
This is because set_install_rpath() is defined in the top-level networking-recipe CMakeLists.txt file, which is not executed in standalone build mode.
Addressed the issue by moving the function definition to its own file (SetInstallPath.cmake) and including it from standalone.cmake in the krnlmon build.
This commit is associated with ipdk-io/networking-recipe#541.