Improve error handling in es2k/switch_pd_fdb.c #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In switch_pd_l2_rx_forward_table_entry(): - Renamed 'status' variable to 'tdi_status', to make it clear whether we are handling a tdi or a switch status code. - Defined a distinct 'dealloc_status' variable to hold the status of the call to tdi_switch_pd_deallocate_resources(). - Added arbitration logic to select the status code to be returned to the caller. Signed-off-by: Derek Foster <[email protected]>
ffoulkes
requested review from
5abeel,
n-sandeep and
vsureshkumarp
as code owners
ffoulkes
commented
Oct 4, 2024
| @@ -475,22 +476,23 @@ switch_status_t switch_pd_l2_rx_forward_table_entry( | |||
| goto dealloc_resources; | |||
| } | |||
|
|
|||
| status = switch_pd_get_bridge_id(device, (uint8_t)api_l2_rx_info->port_id, | |||
| (uint8_t*)&api_l2_rx_info->bridge_id); | |||
| switch_status = | |||
There was a problem hiding this comment.
The original logic assigned the return code from switch_pd_get_bridge_id() (type switch_status_t) to the variable status (type tdi_status_t) and then checked the variable switch_status to see if there was an error.
I renamed status to tdi_status because the former is ambiguous in a function that handles both tdi and switch status codes, and this is a bad thing (as evidenced by the fact that the original coder confused the two).
Signed-off-by: Derek Foster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In switch_pd_l2_rx_forward_table_entry():
Renamed 'status' variable to 'tdi_status', to make it clear whether we are handling a tdi or a switch status code.
Defined a distinct 'cleanup_status' variable to hold the status of the call to tdi_switch_pd_deallocate_resources().
Added arbitration logic to select the status code to return to the caller.