Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ovsp4rt] Enable BUILD_CLIENT if BUILD_JOURNAL enabled #739

Merged
merged 2 commits into from
Jan 23, 2025
Merged

[ovsp4rt] Enable BUILD_CLIENT if BUILD_JOURNAL enabled #739

merged 2 commits into from
Jan 23, 2025

Conversation

ffoulkes
Copy link
Contributor

@ffoulkes ffoulkes commented Jan 22, 2025 •
edited
Loading

  • Updated cmake file to set the default value of the BUILD_CLIENT option to the value of the BUILD_JOURNAL option.

@ffoulkes ffoulkes changed the title [ovsp4rt] Default to BUILD_CLIENT if BUILD_JOURNAL enabled [ovsp4rt] Enable BUILD_CLIENT if BUILD_JOURNAL enabled Jan 22, 2025
@ffoulkes ffoulkes added trivial effort Almost no effort required cmake Affects CMake build system labels Jan 22, 2025
5abeel
5abeel approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ffoulkes ffoulkes merged commit c8e36a7 into main Jan 23, 2025
10 checks passed
@ffoulkes ffoulkes deleted the journal-sets-client branch January 23, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5abeel 5abeel 5abeel approved these changes

@n-sandeep n-sandeep Awaiting requested review from n-sandeep n-sandeep is a code owner

@vsureshkumarp vsureshkumarp Awaiting requested review from vsureshkumarp vsureshkumarp is a code owner

Assignees
No one assigned
Labels
cmake Affects CMake build system trivial effort Almost no effort required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffoulkes @5abeel