Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add page copy #57

Merged
merged 8 commits into from
Nov 29, 2018
Merged

chore: add page copy #57

merged 8 commits into from
Nov 29, 2018

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Nov 27, 2018

Closes #41.

@fsdiogo fsdiogo self-assigned this Nov 27, 2018
@ghost ghost added the status/in-progress In progress label Nov 27, 2018
@fsdiogo
Copy link
Contributor Author

fsdiogo commented Nov 29, 2018

Add with jsipfs fallback Download with jsipfs fallback
add-fallback download-fallback
Add with local daemon Download with local daemon
add-daemon download-daemon

@fsdiogo fsdiogo changed the title [WIP] chore: add page copy chore: add page copy Nov 29, 2018
@fsdiogo fsdiogo requested review from lidel and olizilla November 29, 2018 11:47
olizilla
olizilla approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy looks good! Let's add a link from CID to https://docs.ipfs.io/guides/concepts/cid/

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Nov 29, 2018

Took another approach regarding adding the CID link.

Added Learn more links which makes them more visible and actionable, linking to How IPFS works and CID:

learn-more

@fsdiogo fsdiogo merged commit 9ed9c25 into master Nov 29, 2018
@ghost ghost removed the status/in-progress In progress label Nov 29, 2018
@fsdiogo fsdiogo deleted the chore/add-app-copy branch November 29, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla approved these changes

@lidel lidel Awaiting requested review from lidel

Assignees

@fsdiogo fsdiogo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsdiogo @olizilla