Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-test workflow to use ipdxco #700

Closed
wants to merge 1 commit into from

Conversation

gammazero
Copy link
Contributor

Make go-test workflow use ipdxco/unified-github-workflows/.github/workflows/[email protected] and not ipfs/uci/.github/workflows/[email protected]

@gammazero gammazero requested a review from a team as a code owner October 23, 2024 22:07
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.35%. Comparing base (392493d) to head (46f9dfc).

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
- Coverage   60.35%   60.35%   -0.01%     
==========================================
  Files         243      242       -1     
  Lines       31038    31015      -23     
==========================================
- Hits        18734    18719      -15     
+ Misses      10637    10632       -5     
+ Partials     1667     1664       -3     

see 16 files with indirect coverage changes

@lidel
Copy link
Member

lidel commented Oct 23, 2024

Hm.. ubuntu tests fail due to Called workflows cannot be queued onto self-hosted runners across organizations/enterprises. Failed to queue this job. Labels: 'self-hosted , linux , x64 , 2xlarge'.

I think we need help from @ipfs/ipdx to resolve this.

Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ipfs/uci is a fork that is automatically updated by ipdxco/unified-github-workflows (ipdxco/unified-github-workflows@2315cf0 - I just put it on schedule, not sure why it wasn't on it before). Unfortunately, we need this workaround because reusable workflows from outside the organization they're running in, do not have access to self-hosted runners.

@lidel
Copy link
Member

lidel commented Oct 24, 2024

Thanks @galargh, in that case we can close this.

@lidel lidel closed this Oct 24, 2024
@lidel lidel deleted the update-go-test-workflow branch October 24, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants