Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing/http/server): adjust bucket sizes for http metrics #724

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

2color
Copy link
Member

@2color 2color commented Nov 19, 2024

This PR addresses feedback from ipfs/someguy#87 (review) and introduced more realistic size buckets for the response size histogram.

Reference numbers

@2color 2color requested a review from a team as a code owner November 19, 2024 09:12
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.33%. Comparing base (13d0b32) to head (55f0233).
Report is 6 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   60.35%   60.33%   -0.02%     
==========================================
  Files         243      243              
  Lines       31057    31057              
==========================================
- Hits        18744    18738       -6     
- Misses      10643    10650       +7     
+ Partials     1670     1669       -1     
Files with missing lines Coverage Δ
routing/http/server/server.go 74.30% <100.00%> (ø)

... and 7 files with indirect coverage changes


🚨 Try these New Features:

@lidel lidel changed the title fix: use more realistic size buckets for metrics in delegated routing server fix(routing/http/server): adjust bucket sizes for http metrics Nov 19, 2024
@2color 2color merged commit 138b596 into main Nov 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants