Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minor Improvements to providerquerymanager #728

Merged
merged 11 commits into from
Nov 27, 2024

Conversation

gammazero
Copy link
Contributor

@gammazero gammazero commented Nov 26, 2024

Each of the first 5 commits is a stand-alone enhancement.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.32%. Comparing base (8673560) to head (e2965ed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...uting/providerquerymanager/providerquerymanager.go 93.10% 3 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   60.31%   60.32%   +0.01%     
==========================================
  Files         244      244              
  Lines       31034    31015      -19     
==========================================
- Hits        18717    18711       -6     
+ Misses      10644    10633      -11     
+ Partials     1673     1671       -2     
Files with missing lines Coverage Δ
...uting/providerquerymanager/providerquerymanager.go 89.18% <93.10%> (+2.20%) ⬆️

... and 6 files with indirect coverage changes

A counting semaphore is used to liimit the number of concurrent find requests, instead of a fixed number of goroutines. If the configured limit is set to 0, meaning unlimited, then ignore the semaphore.
Copy link
Contributor

@hsanjuan hsanjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... although I think the improvements may be not so minor ;)

routing/providerquerymanager/providerquerymanager.go Outdated Show resolved Hide resolved
routing/providerquerymanager/providerquerymanager.go Outdated Show resolved Hide resolved
@gammazero gammazero merged commit 821f539 into main Nov 27, 2024
15 checks passed
@gammazero gammazero deleted the improve-providerquerymanager branch November 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants