-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: finish porting and cleaning all simple tests #92
Conversation
8810853
to
fd6a57d
Compare
e8089a3
to
92d30af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I think we should also prepare an accompanying PR to kubo that removes ported tests from sharness there. (ipfs/kubo#9999)
92d30af
to
7e3d50a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @laurentsenta for driving this over the finish line ❤️
I did a pass over this and dropped some questions/comments/nits to address, but other than that lgtm.
As for Kubo PR, it is bit more tricky, left a review there, butI don't think that PR should block this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"dag" name is confusing because unixfs is a DAG too.
These are CBOR and JSON tests, and dag-
variants are part of the story.
Maybe rename fixtures/path_gateway_dag
→ fixtures/path_gateway_cbor_json
for clarity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to my other comments about naming and specs (#92 (comment)) I'd keep this in a different PR if that's OK with you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit _dag_
in filename is confusing – CARs and UnixFS also have DAGs.
These are CBOR and JSON tests, and dag-
variants are only part of the story.
Maybe rename tests/path_gateway_dag_test.go
→ tests/path_gateway_cbor_json_test.go
for clarity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We aligned these file names with the spec changes in #79
Spec defs:
gateway-conformance/tooling/specs/specs.go
Line 115 in de3b04b
PathGatewayDAG = Leaf{"path-dag-gateway", stable} |
I'm worried if we change that filename here, we'll create inconsistencies with the rest of the code, I created #100 to capture your comments.
255de13
to
2711f0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
I think this one is mostly fine, as long as @lidel's comments are addressed. Same in Kubo land: ipfs/kubo#9999 - I think they can merged independently and I would like them to be merged as soon as possible to avoid future conflicts.
Co-authored-by: Marcin Rataj <[email protected]>
d921d62
to
7a2a26d
Compare
Closes #26
Notes
/api/
, behavior with configs, etc.