-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI and API command output encoding #215
Draft
jbouwman
wants to merge
9
commits into
ipfs:master
Choose a base branch
from
jbouwman:display-cli
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Sep 8, 2021
-
Add Command.DisplayCLI method signature
Following the approach described in ipfs#115, define a new method signature on `Command` that supports full processing of the `Response` object when text encoding is requested. Add an encoding check and dispatch to DisplayCLI in local, http client, and http handler code paths. Unblocks resolution of `encoding` option processing in multiple go-ipfs issues. - ipfs/kubo#7050 json encoding for `ls` - ipfs/kubo#1121 json encoding for `add` - ipfs/kubo#5594 json encoding for `stats bw`
Configuration menu - View commit details
-
Copy full SHA for 957684f - Browse repository at this point
Copy the full SHA 957684fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16f14e9 - Browse repository at this point
Copy the full SHA 16f14e9View commit details -
- When both PostRun (output transformer) and DisplayCLI (terminal output) are present, ensure that both are run. `EmitResponse` helper in executor.go is invoked by both local and HTTP client executors: the client fibs the command.Run interface via anonymous function.
Configuration menu - View commit details
-
Copy full SHA for 11083f0 - Browse repository at this point
Copy the full SHA 11083f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9bff5f3 - Browse repository at this point
Copy the full SHA 9bff5f3View commit details
Commits on Sep 23, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ed1225f - Browse repository at this point
Copy the full SHA ed1225fView commit details -
Read from display error channel in EmitResponse
Close the channel immediately if it will never be used.
Configuration menu - View commit details
-
Copy full SHA for f47dce6 - Browse repository at this point
Copy the full SHA f47dce6View commit details
Commits on Sep 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d3455df - Browse repository at this point
Copy the full SHA d3455dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for bce8c65 - Browse repository at this point
Copy the full SHA bce8c65View commit details
Commits on Apr 28, 2022
-
Merge branch 'ipfs:master' into display-cli
Jesse Bouwman authoredApr 28, 2022 Configuration menu - View commit details
-
Copy full SHA for 11a3754 - Browse repository at this point
Copy the full SHA 11a3754View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.