Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ts-ignore for go-ipfs import #200

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

achingbrain
Copy link
Member

The next version of npm-go-ipfs has types so the @ts-expect-error prevents using the pre-release version of npm-go-ipfs.

The next version of npm-go-ipfs has types so the `@ts-expect-error`
prevents using the pre-release version of npm-go-ipfs.
@achingbrain achingbrain requested a review from a team as a code owner August 1, 2023 16:39
Copy link

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/runner/work/helia/helia/packages/interop/test/fixtures/create-kubo.ts:1:1: Do not use "@ts-ignore" because it alters compilation errors. [Error/@typescript-eslint/ban-ts-comment]

🤣

@achingbrain achingbrain merged commit 9036471 into main Aug 1, 2023
17 checks passed
@achingbrain achingbrain deleted the chore/use-ts-ignore-for-go-ipfs branch August 1, 2023 16:53
Jorropo added a commit to ipfs/kubo that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants