Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add QR Code to ShareModal #2320

Merged
merged 4 commits into from
Jan 29, 2025
Merged

feat: add QR Code to ShareModal #2320

merged 4 commits into from
Jan 29, 2025

Conversation

badgooooor
Copy link
Contributor

@badgooooor badgooooor commented Jan 25, 2025 •
edited by SgtPooki
Loading

Description

Result of updated ShareModal in storybook:
image

Fixes #1358

@badgooooor badgooooor requested a review from a team as a code owner January 25, 2025 03:06
@welcome Welcome
Copy link

welcome bot commented Jan 25, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines
    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@SgtPooki
Copy link
Member

Thanks for throwing this together! I enabled CI to run and will be checking out the code

lidel
lidel reviewed Jan 29, 2025
View reviewed changes
src/files/modals/share-modal/ShareModal.js Outdated
@@ -9,8 +10,13 @@ import { Modal, ModalActions, ModalBody } from '../../../components/modal/Modal.
const ShareModal = ({ t, tReady, onLeave, link, className, ...props }) => (
<Modal {...props} className={className} onCancel={onLeave} >
<ModalBody title={t('shareModal.title')} Icon={ShareIcon}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: if we show QR code, we should not waste vertical space for Icon:

image

Then, thanks to reclaimed space, you can make QR code bigger.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited as suggested

image

@badgooooor
Copy link
Contributor Author

Thanks for throwing this together! I enabled CI to run and will be checking out the code

@SgtPooki I'm not quite sure why CI got dependency check error on installed packages which is used in this pull request. Is there anything I need to fix furthur? (Ref: deps-check run attempt in Github Action)

@badgooooor badgooooor requested a review from lidel January 29, 2025 07:52
@badgooooor badgooooor changed the title Add QR Code to ShareModal feat: add QR Code to ShareModal Jan 29, 2025
@SgtPooki
Copy link
Member

Thanks for throwing this together! I enabled CI to run and will be checking out the code

@SgtPooki I'm not quite sure why CI got dependency check error on installed packages which is used in this pull request. Is there anything I need to fix furthur? (Ref: deps-check run attempt in Github Action)

I will check it out on this run

SgtPooki
SgtPooki approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, will check CI failures on latest run and go from there

@SgtPooki SgtPooki linked an issue Jan 29, 2025 that may be closed by this pull request
Generate/display QR code for sharing #1358
Closed
@SgtPooki SgtPooki merged commit 5dbccfd into ipfs:main Jan 29, 2025
20 checks passed
@lidel lidel mentioned this pull request Jan 30, 2025
Open
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtPooki SgtPooki SgtPooki approved these changes

@lidel lidel Awaiting requested review from lidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate/display QR code for sharing
3 participants
@badgooooor @SgtPooki @lidel