Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix bitswap tests #645

Closed
wants to merge 2 commits into from
Closed

fix bitswap tests #645

wants to merge 2 commits into from

Conversation

daviddias
Copy link
Member

@daviddias daviddias commented Dec 8, 2016 •
edited
Loading

bitswap tests started failing for some reason (last time master had a merged they worked perfectly). Still figuring this one out.

The block is never exchanged

@daviddias daviddias added status/in-progress In progress kind/bug A bug in existing code (including security flaws) labels Dec 8, 2016
@daviddias daviddias self-assigned this Dec 9, 2016
@daviddias
Copy link
Member Author

daviddias commented Dec 9, 2016 •
edited
Loading

figured it out, it was a regression in js-ipfs-api. releasing and fixing :)

UPDATE: Spoke too soon :(

@daviddias
Copy link
Member Author

daviddias commented Dec 9, 2016 •
edited
Loading

Gettting there, messages are being sent, but empty

 bitswap:network data from QmTTLyjea7cKxFJd3TjYnKbvZBwqh1EQbhnrZ2482xsyVg +3ms
  bitswap:engine received empty message from QmTTLyjea7cKxFJd3TjYnKbvZBwqh1EQbhnrZ2482xsyVg +0ms
  bitswap:network data from QmTTLyjea7cKxFJd3TjYnKbvZBwqh1EQbhnrZ2482xsyVg +0ms
  bitswap:engine received empty message from QmTTLyjea7cKxFJd3TjYnKbvZBwqh1EQbhnrZ2482xsyVg +0ms
  bitswap:network data from QmTTLyjea7cKxFJd3TjYnKbvZBwqh1EQbhnrZ2482xsyVg +19ms
  bitswap:engine received empty message from QmTTLyjea7cKxFJd3TjYnKbvZBwqh1EQbhnrZ2482xsyVg +1ms
  bitswap:network data from QmTTLyjea7cKxFJd3TjYnKbvZBwqh1EQbhnrZ2482xsyVg +1ms
  bitswap:engine received empty message from QmTTLyjea7cKxFJd3TjYnKbvZBwqh1EQbhnrZ2482xsyVg +0ms

@daviddias
Copy link
Member Author

@dignifiedquire could help me with this one?

@daviddias daviddias changed the title wip fix bitswap tests Dec 9, 2016
@dignifiedquire
Copy link
Member

@diasdavid no need to fix anything in js-ipfs. The bug is in aegir, or rather in a nested dependency: ipfs/aegir#79 (comment)

@dignifiedquire
Copy link
Member

Should be fixed in [email protected]

@dignifiedquire dignifiedquire removed the status/in-progress In progress label Dec 9, 2016
@daviddias daviddias deleted the fix/bitswap-tests branch December 19, 2016 03:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@daviddias daviddias

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daviddias @dignifiedquire