Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow daemon to start correctly if the API is null #10062

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Aug 11, 2023

Fixes: #10056

@Jorropo Jorropo added the skip/changelog This change does NOT require a changelog entry label Aug 11, 2023
@Jorropo Jorropo requested a review from a team as a code owner August 11, 2023 01:34
test/cli/daemon_test.go Outdated Show resolved Hide resolved
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix test.

@hacdias
Copy link
Member

hacdias commented Nov 20, 2023

Ping @Jorropo

@hacdias hacdias force-pushed the fix/10056 branch 2 times, most recently from d37cf6c to 351d27f Compare December 11, 2023 10:30
@hacdias hacdias merged commit 8c4bdd8 into master Dec 11, 2023
23 checks passed
@hacdias hacdias deleted the fix/10056 branch December 11, 2023 10:45
@hacdias hacdias mentioned this pull request Dec 11, 2023
9 tasks
Jorropo added a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/changelog This change does NOT require a changelog entry
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Panics on startup
2 participants