chore: upgrade to Go 1.20 #10068
Merged
chore: upgrade to Go 1.20 #10068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
changed the title
hacdias
force-pushed
the
go-1.20
branch
4 times, most recently
from
adffe99 to
e9f3af8
Compare
Jorropo
reviewed
Aug 15, 2023
hacdias
force-pushed
the
go-1.20
branch
4 times, most recently
from
000b903 to
3c1c3b9
Compare
2 tasks
1 task
2 tasks
hacdias
removed
the
skip/changelog
lidel
reviewed
Aug 17, 2023
hacdias
force-pushed
the
go-1.20
branch
4 times, most recently
from
9ffabbe to
37bdf9d
Compare
Closed
- Bumps golangci-lint to work for the new Go version - Removes rand.Seed, which has been deprecated. It is seeded by default with a random value since Go 1.20. - Replaces deprecated Fuse errors with syscall.Errno
The way we create the kubo binary for coverage is very hacky.
It uses the testing tool. In order to simulate a Kubo binary,
we need to supress all the output that would otherwise be printed
by 'go test'.
So far, we were setting os.Stdout and os.Stderr as a read-only
/dev/null file descriptor. This is causing issues with the new
versions of Go:
error generating coverage report: write /dev/null: bad file descriptor
exit status 2
Updating it to a Read-Write file descriptor solves the problem.
I did not try looking into what is causing this issue now. There have
been some updates to the 'go test' tool in Go 1.20 and it is likely
that some error is now being checked for that hasn't been checked
before. Writing to a read-only file descriptor always failed. But
the error was just supressed somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10065.
kubo/client/rpcautomatically updated with this PRgo-ipfs-api: chore: version 0.7.0 go-ipfs-api#307go-ipfs-cmdsupdated