Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): JSON and CBOR response formats (IPIP-328) #9335

Merged
merged 39 commits into from
Dec 5, 2022
Merged

feat(gateway): JSON and CBOR response formats (IPIP-328) #9335

merged 39 commits into from
Dec 5, 2022

Commits on Nov 9, 2022

  1. wip: play with dag-cbor and dag-json

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    ac8f9b1 View commit details
    Browse the repository at this point in the history

  2. wip: add application/json and application/cbor

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    3dce012 View commit details
    Browse the repository at this point in the history

  3. fix: go cases don't flow automatically :)

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    b557181 View commit details
    Browse the repository at this point in the history

  4. test: add some dag-json and dag-cbor tests

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    4104bb7 View commit details
    Browse the repository at this point in the history

  5. test: improve names

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    25893c5 View commit details
    Browse the repository at this point in the history

  6. feat: allow json and cbor data types too

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    e621e64 View commit details
    Browse the repository at this point in the history

  7. refactor: avoid encoding things that are already on their right encoding

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    44946ed View commit details
    Browse the repository at this point in the history

  8. fix: remove responseFormat from logging

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    199ab42 View commit details
    Browse the repository at this point in the history

  9. refactor: simplify serveCodec to use serveRawBlock iff data encoded i… 

    …n output encoding
    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    89eb033 View commit details
    Browse the repository at this point in the history

  10. tests: rename current tests to indicate they're unixfs only

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    fb50869 View commit details
    Browse the repository at this point in the history

  11. refactor: do not use serveRawBlock inside serveCodec bc headers and o… 

    …ther options
    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    fc31241 View commit details
    Browse the repository at this point in the history

  12. test: add test with pure json and cbor

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    55383cd View commit details
    Browse the repository at this point in the history

  13. test: convert cbor <-> json

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    a6d45c7 View commit details
    Browse the repository at this point in the history

  14. test: path traversal and dag-pb output

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    1986be1 View commit details
    Browse the repository at this point in the history

  15. fix: add more info about errors

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    9ef022e View commit details
    Browse the repository at this point in the history

  16. fix: add missing traversal

    @hacdias
    hacdias committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    cadc681 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2022

  1. Merge branch 'master' into feat/8823

    @hacdias
    hacdias committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    6331695 View commit details
    Browse the repository at this point in the history

  2. fix: remove duplicate variable

    @hacdias
    hacdias committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    2c93672 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Merge branch 'master' into feat/8823

    @hacdias
    hacdias committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    462c71b View commit details
    Browse the repository at this point in the history

  2. refactor: do not support traversal

    @hacdias
    hacdias committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    1e844c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Update core/corehttp/gateway_handler_codec.go 

    Co-authored-by: Marcin Rataj <[email protected]>
    @hacdias @lidel
    hacdias and lidel authored Nov 15, 2022
    Configuration menu
    Copy the full SHA
    bb98041 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. improve PR to match spec

    @hacdias
    hacdias committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    53d5878 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/8823

    @hacdias
    hacdias committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    4064f97 View commit details
    Browse the repository at this point in the history

  3. feat: little web page

    @hacdias
    hacdias committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    8c6a8da View commit details
    Browse the repository at this point in the history

  4. feat: update doc

    @hacdias
    hacdias committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    b5e5ff2 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. fix: Content-Disposition .json and .cbor 

    .dag- veriants are not necessary – DAG-JSON should have 'Save As'
dialog default to file named .json

see "File extension" section of specs below:

https://www.iana.org/assignments/media-types/application/vnd.ipld.dag-json
https://www.iana.org/assignments/media-types/application/vnd.ipld.dag-cbor
    @lidel
    lidel committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    8ca2a52 View commit details
    Browse the repository at this point in the history

  2. fix: inline disposition for JSON responses 

    Quality of life improvement, allows user agents to render JSON.
Passing ?format=json to unixfs directory will show JSON in browser.
    @lidel
    lidel committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    b4dfa66 View commit details
    Browse the repository at this point in the history

  3. refactor: return 501 for unsupported pathing 

    Includes human-readable error which encourages people to use CBOR Tag 42
for building DAGs with Links.
    @lidel
    lidel committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    83913c7 View commit details
    Browse the repository at this point in the history

  4. docs(cbor): improved info about codec 

    This ensures user knows why they got this HTML response (due to specific
codec in the specific CID they can inspect), and that they
have clear understanding of options – either preview as JSON, or
download as one of supported formats.
    @lidel
    lidel committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    ff55745 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. refactor: create template at assets/dag-index-html 

    This is a quick, static placeholder that follows the style of dir-index-html.
Future work will refine this, perhaps by reusing parts of https://explore.ipld.io/
    @lidel
    lidel committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    52711d3 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. fix(dag@gw): content type and cache headers 

    This unifies the way we set headers for DAG- responses, adds missing
ones for HTML response, and adds bunch of regression tests to ensure
desired behaviors are not changed during future refactors.
    @lidel
    lidel committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    7e84856 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Merge branch 'master' into feat/8823

    @hacdias
    hacdias committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    3b89f20 View commit details
    Browse the repository at this point in the history

  2. add changelog info

    @hacdias
    hacdias committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    162f435 View commit details
    Browse the repository at this point in the history

  3. fix title

    @hacdias
    hacdias committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    12d0d7f View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. rm wild block

    @hacdias
    hacdias committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    2d8ba78 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge branch 'master' into feat/8823

    @hacdias
    hacdias authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    b5874e7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/8823

    @hacdias
    hacdias authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    0c08a76 View commit details
    Browse the repository at this point in the history

  3. fix(dag-index-html): remove technical jargon 

    Applied feedback from IPFS Implementers Sync,
HTML should be aimed at non-technical people,
and UnixFS in bold is too intimidating.
    @lidel
    lidel committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    f084f09 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feat/8823

    @lidel
    lidel authored Dec 5, 2022
    Configuration menu
    Copy the full SHA
    32bcd41 View commit details
    Browse the repository at this point in the history