-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release v1.5.0 #158
Conversation
setup_bitswap.go
Outdated
func (*noopPeerLedger) Wants(p peer.ID, e wl.Entry) bool { | ||
return false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old rainbow had this noopPeerLogger
implementation and i had to start returning a bool
after updating boxo here.
Seems that hardcoding false
here causes panic
in
https://github.com/ipfs/boxo/blob/v0.22.0/bitswap/server/internal/decision/engine.go#L876
panic: runtime error: index out of range [0] with length 0
go test
log here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed noopPeerLedger
.
Rationale:
- After looking at things bit deeper I realized
WithPeerBlockRequestFilter
is enough and customPeerLedger
does not help us with anything, and after overflow fixes in boxo 0.22 only causes problems (because we do wantPeerLedger
that correctly tracks wants that are not filtered byWithPeerBlockRequestFilter
). - Low risk since
RAINBOW_SEED_PEERING
isfalse
by default, and it is marked as experimental feature (that we decided to not use in our infra).
boxo v0.22.0 changed the way ledger interacts with overflow and this noop no longer works WithPeerBlockRequestFilter should be enough for now
164c3b4
to
7ceaa42
Compare
Suggested version: Changes in configuration file(s): diff --git a/go.mod b/go.mod
index 58381d7..aa40d01 100644
--- a/go.mod
+++ b/go.mod
@@ -20,6 +20,7 @@ require (
github.com/ipfs/go-log/v2 v2.5.1
github.com/ipfs/go-metrics-interface v0.0.1
github.com/ipfs/go-metrics-prometheus v0.0.2
+ github.com/ipfs/go-test v0.0.2
github.com/ipfs/go-unixfsnode v1.9.0
github.com/ipld/go-codec-dagpb v1.6.0
github.com/libp2p/go-libp2p v0.35.1
Cutting a Release (and modifying non-markdown files)This PR is modifying both Automatically created GitHub ReleaseA draft GitHub Release has been created. |
This PR is bare minimum to be able to bump dependencies with various upstream bugfixes: