Error instead of dropping unauthorized headers #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re not there or incorrect rather than silently ignoring those headers
aschmahmann
force-pushed
the
fix/401-unauthorized-headers
branch
from
98631c2
to
b7e0356
Compare
gammazero
reviewed
Nov 20, 2024
Co-authored-by: Andrew Gillis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously just didn't honor headers that required authorization but didn't provide it, this errors making things more explicit and less error prone. @gammazero just ran into some confusion here and it seems like being more explicit here could be helpful.
WDYT @lidel?