Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable verified-fetch server-timing headers #552

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jan 22, 2025

Title

fix: enable verified-fetch server-timing headers

Description

Passes the withServerTiming option to verified-fetch to enable server-timing headers.

Notes & open questions

Tested locally with npm run start and going to http://specs-ipfs-tech.ipns.helia-sw-gateway.localhost/ and checking the server-timing headers in the network tab.

image

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review. note that this PR also updates package-lock.json because I ran npm run reset && npm i

@SgtPooki SgtPooki merged commit 08828d8 into main Jan 22, 2025
17 checks passed
@SgtPooki SgtPooki deleted the fix/enable-server-timing branch January 22, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant