feat: Replace http(s) with node-fetch
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum version increases to 14.
max-ipinfo
approved these changes
Nov 13, 2024
|
@max-ipinfo added the changelog entry and new version. I've also simplified the documentation and added information about catching errors as a best practice. The documentation includes separate TypeScript and JavaScript examples but as TypeScript can run all JavaScript we do not need separate examples: I have consolidated the examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82
Replaces
http(s)withnode-fetch. The public-facing API of the library is unchanged but the mechanism for communicating with the API has changed and could manifest in different behaviour, e.g: previously we were handling errors in different places with different logic. There's also an increase in the minimum node version from 10 to 14.Added a Workflow to test the library with each supported version of node.