Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
UmanShahzad authored Nov 21, 2023
1 parent 5bf8fba commit da9fc0e
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions test/lib/adapter_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@
require 'faraday/httpclient'
require 'faraday/excon'

# No updates since 2021, the method `dependecy` from the class Faraday::Adapter has been removed
# https://github.com/lostisland/faraday/blob/main/UPGRADING.md#the-dependency-method-in-middlewares-has-been-removed
# require 'faraday/em_http'
# require 'faraday/em_synchrony'

class IPinfo::AdapterTest < Minitest::Test
def test_default
adapter = IPinfo::Adapter.new
Expand All @@ -28,8 +23,6 @@ def test_default
net_http_persistent: Faraday::Adapter::NetHttpPersistent,
typhoeus: Faraday::Adapter::Typhoeus,
patron: Faraday::Adapter::Patron,
# em_synchrony: Faraday::Adapter::EMSynchrony,
# em_http: Faraday::Adapter::EMHttp,
excon: Faraday::Adapter::Excon,
httpclient: Faraday::Adapter::HTTPClient
}.freeze
Expand Down

0 comments on commit da9fc0e

Please sign in to comment.