Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, upgrade unified-ci #371

Merged
merged 12 commits into from
Feb 14, 2023
Merged

Update dependencies, upgrade unified-ci #371

merged 12 commits into from
Feb 14, 2023

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Feb 14, 2023

Replaces #366

upgraded dependencies in v0, v2 and cmd

Also added a dependabot conifg, the only catch with that is I don't know if I should use /cmd/car or /cmd. The go.mod is in /cmd, but you can't run go get from in there. If nobody else knows what's the right way to do that then we can proceed as is and fix later if it doesn't update properly.

@rvagg rvagg requested a review from willscott February 14, 2023 10:09
@rvagg
Copy link
Member Author

rvagg commented Feb 14, 2023

The macos CI failure is from rogpeppe/go-internal#200, which is still unsolved. We're either going to have to live with it, migrate to a new tool, or figure out how to get unified-ci to downgrade our macos version in the OS matrix.

@rvagg
Copy link
Member Author

rvagg commented Feb 14, 2023

hat tip to @laurentsenta for the hot tip that we can use UCI_GO_TEST_RUNNER_MACOS as a repo variable in here to downgrade the macos runner to "macos-11" so go-internal doesn't keep on failing on us while rogpeppe/go-internal#200 remains unresolved.

The trick now will be remembering that this is set so that when GitHub retires macos-11 we don't have to scratch our heads why we're still using it here; cause it's kind of tucked away.

@rvagg rvagg merged commit 2624c5e into master Feb 14, 2023
@rvagg rvagg deleted the rvagg/deps branch February 14, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants