Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.14.2 bump #541

Merged
merged 1 commit into from
Sep 25, 2024
Merged

v2.14.2 bump #541

merged 1 commit into from
Sep 25, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Sep 25, 2024

No description provided.

Copy link
Contributor

Suggested version: 2.14.2

Comparing to: v2.14.1 (diff)

Changes in configuration file(s):

diff --git a/cmd/go.mod b/cmd/go.mod
index 499fbac..7f5bd15 100644
--- a/cmd/go.mod
+++ b/cmd/go.mod
@@ -11,14 +11,14 @@ require (
 	github.com/ipfs/go-ipld-format v0.6.0
 	github.com/ipfs/go-unixfsnode v1.9.1
 	github.com/ipld/go-car v0.6.2
-	github.com/ipld/go-car/v2 v2.14.0
+	github.com/ipld/go-car/v2 v2.14.1
 	github.com/ipld/go-codec-dagpb v1.6.0
 	github.com/ipld/go-ipld-prime v0.21.0
 	github.com/multiformats/go-multicodec v0.9.0
 	github.com/multiformats/go-multihash v0.2.3
 	github.com/multiformats/go-varint v0.0.7
 	github.com/polydawn/refmt v0.89.0
-	github.com/rogpeppe/go-internal v1.12.0
+	github.com/rogpeppe/go-internal v1.13.1
 	github.com/urfave/cli/v2 v2.27.4
 	golang.org/x/exp v0.0.0-20240909161429-701f63a606c0
 )
diff --git a/v2/go.mod b/v2/go.mod
index 4ff6afa..6a3ee30 100644
--- a/v2/go.mod
+++ b/v2/go.mod
@@ -7,7 +7,7 @@ require (
 	github.com/ipfs/go-cid v0.4.1
 	github.com/ipfs/go-ipld-cbor v0.1.0
 	github.com/ipfs/go-ipld-format v0.6.0
-	github.com/ipfs/go-unixfsnode v1.9.0
+	github.com/ipfs/go-unixfsnode v1.9.1
 	github.com/ipld/go-codec-dagpb v1.6.0
 	github.com/ipld/go-ipld-prime v0.21.0
 	github.com/ipld/go-ipld-prime/storage/bsadapter v0.0.0-20230102063945-1a409dc236dd
@@ -23,14 +23,14 @@ require (
 require (
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
-	github.com/google/uuid v1.3.0 // indirect
-	github.com/hashicorp/golang-lru v0.5.4 // indirect
+	github.com/google/uuid v1.6.0 // indirect
+	github.com/hashicorp/golang-lru v1.0.2 // indirect
 	github.com/ipfs/bbloom v0.0.4 // indirect
+	github.com/ipfs/boxo v0.22.0 // indirect
 	github.com/ipfs/go-bitfield v1.1.0 // indirect
 	github.com/ipfs/go-datastore v0.6.0 // indirect
-	github.com/ipfs/go-ipfs-blockstore v1.2.0 // indirect
-	github.com/ipfs/go-ipfs-chunker v0.0.5 // indirect
-	github.com/ipfs/go-ipfs-ds-help v1.1.0 // indirect
+	github.com/ipfs/go-ipfs-blockstore v1.3.1 // indirect
+	github.com/ipfs/go-ipfs-ds-help v1.1.1 // indirect
 	github.com/ipfs/go-ipfs-util v0.0.3 // indirect
 	github.com/ipfs/go-log v1.0.5 // indirect
 	github.com/ipfs/go-log/v2 v2.5.1 // indirect
@@ -38,7 +38,7 @@ require (
 	github.com/jbenet/goprocess v0.1.4 // indirect
 	github.com/klauspost/cpuid/v2 v2.2.8 // indirect
 	github.com/libp2p/go-buffer-pool v0.1.0 // indirect
-	github.com/mattn/go-isatty v0.0.17 // indirect
+	github.com/mattn/go-isatty v0.0.20 // indirect
 	github.com/minio/sha256-simd v1.0.1 // indirect
 	github.com/mr-tron/base58 v1.2.0 // indirect
 	github.com/multiformats/go-base32 v0.1.0 // indirect
@@ -50,13 +50,13 @@ require (
 	github.com/spaolacci/murmur3 v1.1.0 // indirect
 	github.com/whyrusleeping/cbor-gen v0.1.2 // indirect
 	github.com/whyrusleeping/chunker v0.0.0-20181014151217-fe64bd25879f // indirect
-	go.uber.org/atomic v1.10.0 // indirect
-	go.uber.org/multierr v1.9.0 // indirect
-	go.uber.org/zap v1.24.0 // indirect
+	go.uber.org/atomic v1.11.0 // indirect
+	go.uber.org/multierr v1.11.0 // indirect
+	go.uber.org/zap v1.27.0 // indirect
 	golang.org/x/crypto v0.27.0 // indirect
 	golang.org/x/sys v0.25.0 // indirect
 	golang.org/x/xerrors v0.0.0-20240903120638-7835f813f4da // indirect
-	google.golang.org/protobuf v1.28.1 // indirect
+	google.golang.org/protobuf v1.34.2 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 	lukechampine.com/blake3 v1.3.0 // indirect
 )

gorelease says:

# github.com/ipld/go-car/v2
## incompatible changes
AllowDuplicatePuts: removed
ApplyOptions: removed
AttachIndex: removed
BlockMetadata: removed
BlockReader: removed
Characteristics: removed
CharacteristicsSize: removed
DefaultMaxAllowedHeaderSize: removed
DefaultMaxAllowedSectionSize: removed
DefaultMaxIndexCidSize: removed
ErrAlreadyV1: removed
ErrCidTooLarge: removed
ErrOffsetImpossible: removed
ErrSizeMismatch: removed
ExtractV1File: removed
GenerateIndex: removed
GenerateIndexFromFile: removed
Header: removed
HeaderSize: changed from const to func
LoadIndex: removed
MaxAllowedHeaderSize: removed
MaxAllowedSectionSize: removed
MaxIndexCidSize: removed
NewBlockReader: removed
NewHeader: removed
NewReader: removed
NewSelectiveWriter: removed
OpenReader: removed
Options.BlockstoreAllowDuplicatePuts: removed
Options.BlockstoreUseWholeCIDs: removed
Options.DataPadding: removed
Options.IndexCodec: removed
Options.IndexPadding: removed
Options.MaxAllowedHeaderSize: removed
Options.MaxAllowedSectionSize: removed
Options.MaxIndexCidSize: removed
Options.StoreIdentityCIDs: removed
Options.TraversalPrototypeChooser: removed
Options.TrustedCAR: removed
Options.WriteAsCarV1: removed
Options.ZeroLengthSectionAsEOF: removed
Options: removed
Pragma: removed
PragmaSize: removed
ReadOption: removed
ReadOrGenerateIndex: removed
ReadVersion: removed
ReadWriteOption: removed
Reader: removed
ReplaceRootsInFile: removed
SectionReader: removed
Stats: removed
StoreIdentityCIDs: removed
TraverseToFile: removed
TraverseV1: removed
UseDataPadding: removed
UseIndexCodec: removed
UseIndexPadding: removed
UseWholeCIDs: removed
WithTraversalPrototypeChooser: removed
WithTrustedCAR: removed
WithoutIndex: removed
WrapV1: removed
WrapV1File: removed
WriteAsCarV1: removed
WriteOption: removed
Writer: removed
ZeroLengthSectionAsEOF: removed
## compatible changes
Block: added
CarHeader: added
CarReader: added
CarReaderOption: added
Dag: added
DefaultWalkFunc: added
LoadCar: added
NewCarReader: added
NewCarReaderWithOptions: added
NewSelectiveCar: added
OnCarHeaderFunc: added
OnNewCarBlockFunc: added
Options.TraverseLinksOnlyOnce: added
ReadHeader: added
ReadStore: added
SelectiveCar: added
SelectiveCarPrepared: added
Store: added
TraverseLinksOnlyOnce: added
WalkFunc: added
WithErrorOnEmptyRoots: added
WriteCar: added
WriteCarWithWalker: added
WriteHeader: added

# github.com/ipld/go-car/v2/blockstore
## incompatible changes
package removed

# github.com/ipld/go-car/v2/index
## incompatible changes
package removed

# github.com/ipld/go-car/v2/storage
## incompatible changes
package removed

# github.com/ipld/go-car/v2/storage/deferred
## incompatible changes
package removed

# github.com/ipld/go-car/util
## compatible changes
package added

# summary
Cannot suggest a release version.
Base module path is different from release.

gocompat says:

HEAD is now at 92d3f4e v2.14.1 bump
Previous HEAD position was 92d3f4e v2.14.1 bump
Switched to branch 'master'
Your branch is up to date with 'origin/master'.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@rvagg
Copy link
Member Author

rvagg commented Sep 25, 2024

https://github.com/ipld/go-car/actions/runs/11027862042/job/30626938814

So, it runs, but because it depends on Releaser completing we get it running when it shouldn't; I recall now we had this problem with lassie too, the compromise for getting this to run also involved having it run sometimes when it shouldn't. But because Releaser is only run on version.json edits, it's not as annoying as having it run on every commit, and only the creator gets the notification I think.

@rvagg
Copy link
Member Author

rvagg commented Sep 25, 2024

Will merge and I think it'll run again, because Releaser will, but this time it'll find a good tag. I guess we could put some logic into the workflow to do this test beforehand so it doesn't execute the goreleaser job.

@rvagg rvagg merged commit 40add1a into master Sep 25, 2024
21 checks passed
@rvagg rvagg deleted the rvagg/v2.14.2 branch September 25, 2024 06:59
@rvagg
Copy link
Member Author

rvagg commented Sep 25, 2024

https://github.com/ipld/go-car/actions/runs/11027936675

and we have binaries

so it works, but it's not ideal since we get the extra "commit isn't tagged" run that we don't need, but it's not the worst thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants